Skip to content

test_runner: fix suite diagnostic chanel end#63533

Open
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-suite-diagnostics-channel
Open

test_runner: fix suite diagnostic chanel end#63533
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-suite-diagnostics-channel

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented May 24, 2026

No description provided.

@MoLow
test_runner: fix suite diagnostic chanel end
467092d 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 24, 2026

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 24, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 24, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73658/

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (df09b2a) to head (467092d).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #63533   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         730      730           
  Lines      234152   234160    +8     
  Branches    43900    43904    +4     
=======================================
+ Hits       211499   211507    +8     
- Misses      14374    14379    +5     
+ Partials     8279     8274    -5
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.90% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi
atlowChemi approved these changes May 24, 2026
View reviewed changes
Comment thread test/parallel/test-runner-diagnostics-channel.js
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 24, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73673/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoLow @nodejs-github-bot @jasnell @atlowChemi